Remove nodecomet transport by default, various minor fixes & refactorings #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that node uses websockets as base transport, the connectivity check transport is no longer the base transport. Rather than add a connectivityCheckTransportPreferenceOrder or something, just use the Http module (and for browsers have xhr and jsonp add their checks to that module, like they do Http.Request); IMO it never made much sense to tie it to the transport
and xhr_streaming mutates the params
paddybyers
reviewed
Mar 8, 2017
spec/common/modules/shared_helper.js
Outdated
| @@ -6,7 +6,14 @@ | |||
| define(['spec/common/modules/testapp_module', 'spec/common/modules/client_module', 'spec/common/modules/testapp_manager', 'async'], | |||
| function(testAppModule, clientModule, testAppManager, async) { | |||
| var utils = clientModule.Ably.Realtime.Utils; | |||
| var availableTransports = utils.keysArray(clientModule.Ably.Realtime.ConnectionManager.supportedTransports), | |||
| var supportedTransports = utils.keysArray(clientModule.Ably.Realtime.ConnectionManager.supportedTransports), | |||
| /* Don't include jsonp in availableTransports if xhr worksk. Why? Because | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.0.0's been out for almost 12 hours, so time for 1.0.1 :)
I was planning to get this in for 1.0 as it's arguably a breaking change, but missed Matt's message last night saying he was going to release it, oh well