-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WEB-4194] Conflation ControlAPI #2416
base: main
Are you sure you want to change the base?
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will suggest some text updates too, but the conflation properties are missing from create.
See WEB-4194 for more details
Add ControlAPI fields to namespaces for conflation, and clean up batching fields
This pull request includes changes to the
static/open-specs/control-v1.yaml
file to update the message batching and conflation configurations. The most important changes involve the removal of thebatchingPolicy
field and the addition of new fields related to message conflation.Changes to message batching and conflation configurations:
batchingPolicy
field from the configuration. [1] [2] [3]batchingInterval
description to clarify its role in determining the frequency of message batching.conflationEnabled
field to enable or disable message conflation.conflationInterval
field to specify the interval at which messages are conflated.conflationKey
field to determine which messages should be conflated based on a key.