-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chat: Adding rest api documentation to chat #2478
base: main
Are you sure you want to change the base?
Conversation
…ng, and deletion.
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
The REST API documentation for sending, updating, deleting, and retrieving chat messages has been moved. It is now exposed via openAPI and is defined in the chat.yaml file.
… REST API section.
The X-Ably-Version header was redundant and not strictly required.
title: Ably Chat REST API | ||
version: 1.0.0 | ||
paths: | ||
/chat/{version}/rooms/{roomId}/messages: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason, the /chat/version
part of this doesn't seem to be appearing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, could you try clearing your node_module file, reinstall and then rebuild?
Removing envelope param, this can be governed by content type. Adding moderation failure response.
9388c24
to
fea74d1
Compare
Added per-response error examples. Added supported content-types. Some small changes in wording for clarity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some small comments, but please see conversation in topic-product for more context in regards to the location of this etc.
Updated the production server URL to "https://main.realtime.ably.net/".
Description
This PR aims to add documentation to cover the various chat REST API endpoints;
Checklist