Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check types in CI #226

Open
sbs2001 opened this issue Jul 15, 2020 · 2 comments · May be fixed by #1815
Open

Check types in CI #226

sbs2001 opened this issue Jul 15, 2020 · 2 comments · May be fixed by #1815
Labels
debt difficulty:easy good first issue

Comments

@sbs2001
Copy link
Collaborator

sbs2001 commented Jul 15, 2020

Since the codebase mostly uses typing the CI should enable a type checking.

Because wrong types are worse than no types at all.

We could start by simply running a mypy check in the CI.
@sbs2001 sbs2001 mentioned this issue Jul 15, 2020
Merged
@abhishak3
Copy link

I would like to work on this issue.

@abhishak3 abhishak3 mentioned this issue Mar 7, 2022
Closed
@suraj-mandal
Copy link

is this issue open or closed? Possible to work on it?

@Rishi-source Rishi-source linked a pull request Mar 15, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
debt difficulty:easy good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds type checking to CI #226 Rishi-source/vulnerablecode
4 participants
@pombredanne @suraj-mandal @sbs2001 @abhishak3