Adds type checking to CI #226 #1815
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rishi Garg <[email protected]>
Rishi-source
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes : #226
Add mypy.ini configuration with intentionally relaxed settings Create type-requirements.txt for type checker dependencies Implement GitHub workflow for multi-version Python type checking Disable specific common error codes to establish a baseline
Future work should:
Fix existing type errors incrementally
Gradually enable more strict error checking
Add proper annotations to Django models
Eventually require type annotations for new code
Signed-off-by: Rishi Garg [email protected]