Add weaknesses data in packages endpoint #1789
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mukund-Menon
force-pushed
the
1632-add-weaknesses-in-packages-api
branch
from
1dcb8f0 to
af30544
Compare
pombredanne
requested changes
Mar 6, 2025
vulnerabilities/api.py
Outdated
| instance=qs, | ||
| many=True, | ||
| context={"request": self.context["request"]}, | ||
| ).data | ||
|
|
||
| for vuln, vuln_instance in zip(vulnerabilities_data, qs): | ||
| vuln["weaknesses"] = [weakness.to_dict() for weakness in vuln_instance.prefetched_weaknesses] |
There was a problem hiding this comment.
Should not this go in the serializer instead?
| ), | ||
| Prefetch( | ||
| "weaknesses", | ||
| queryset=Weakness.objects.all(), |
There was a problem hiding this comment.
I used .all() to ensure a queryset is passed, as omitting it caused a server error. Should we instead be filtering the queryset?
Signed-off-by: Mukund Menon <[email protected]>
Signed-off-by: Mukund Menon <[email protected]>
Mukund-Menon
force-pushed
the
1632-add-weaknesses-in-packages-api
branch
from
90e981f to
6d26273
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1632