Fix: Removed custom paginated and added iterator #1801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shrish0098 <[email protected]>
Dedsec0098
changed the title
keshav-space
requested changes
Mar 12, 2025
There was a problem hiding this comment.
Thanks @Dedsec0098, use the appropriate chunk size in the iterator and also remove the paginated from our base queryset manager.
|
Sure, I'll start making the changes required |
…l.com Signed-off-by: Shrish0098 <[email protected]>
|
Hey @keshav-space I have made the changes you asked, please let me know if any further changes are required. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1798
Changes Made:
@keshav-space I have made the changes according to the issue and it is passing all the tests on my local system, however I am not sure how to exactly run the iterations for advisories to check the new response time can you please suggest me on how can I run those and also If you have any suggestions please let me know I will make the changes required.