[WIP] Move loot-core/client/modals code over to desktop-client package

[joel-jeremy]

The original reason this was designed this way it to share the code with a mobile app. But since we no longer have a mobile app, these codes can now be merged to desktop-client package.

• accounts folder
• app folder
• budgets folder
• modals folder
• notifications folder
• prefs folder
• queries folder
• users folder
• data-hooks folder
• store folder
• files under root loot-core/client folder

There will be some suppressed import warning due to loot-core importing some desktop-client files but this is only temporary until we migrate all the files

Changes done:

1. Move folder from loot-core to desktop-client (vscode does the import updates)
2. Run yarn lint:fix
3. Suppress some @actual-app/web imports in loot-core (temporary until all loot-core/client is moved over to desktop-client)

[github-actions]

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
18	9.02 MB → 9.02 MB (+2 B)	+0.00%

Changeset

File	Δ	Size
src/modals/modalsSlice.ts	🆕 +2.14 kB	0 B → 2.14 kB
home/runner/work/actual/actual/packages/loot-core/src/client/notifications/notificationsSlice.ts	📉 -27 B (-1.72%)	1.54 kB → 1.51 kB
home/runner/work/actual/actual/packages/loot-core/src/client/modals/modalsSlice.ts	🔥 -2.11 kB (-100%)	2.11 kB → 0 B

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset	File Size	% Changed
static/js/index.js	5.95 MB → 5.95 MB (+2 B)	+0.00%

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
static/js/AppliedFilters.js	10.87 kB	0%
static/js/useAccountPreviewTransactions.js	1.69 kB	0%
static/js/es.js	67.81 kB	0%
static/js/en-GB.js	5.92 kB	0%
static/js/indexeddb-main-thread-worker-e59fee74.js	13.5 kB	0%
static/js/uk.js	125.2 kB	0%
static/js/BackgroundImage.js	122.29 kB	0%
static/js/de.js	123.66 kB	0%
static/js/nl.js	101.15 kB	0%
static/js/workbox-window.prod.es5.js	5.69 kB	0%
static/js/en.js	111.33 kB	0%
static/js/pt-BR.js	119.46 kB	0%
static/js/resize-observer.js	18.37 kB	0%
static/js/wide.js	112.76 kB	0%
static/js/fr.js	126.05 kB	0%
static/js/narrow.js	389.39 kB	0%
static/js/ReportRouter.js	1.65 MB	0%

[github-actions]

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
1	2.29 MB	0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
kcab.worker.js	2.29 MB	0%