Skip to content

Split transactions repair tool to remove categories from parent transactions + prevent adding/updating parent transactions with categories #4889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

joel-jeremy
Copy link
Contributor

@joel-jeremy joel-jeremy commented Apr 25, 2025

This fixes an issue where an existing parent transaction is still set to a category and you cannot delete the category due to it being used by a parent transaction. This tool removes those categories from parent transactions so users can delete.

Without this tool, the way to fix the issue it to:

  1. Find which parent transaction is using the category you want to delete (by exporting the DB and querying)
  2. Recreate the split transaction and make sure parent transaction is not set to any category (best to not set category before splitting)
  3. Delete the original split transaction
  4. Delete the category

This PR will also prevent future split transactions from setting the category on any parent transactions.

…ories from parent transactions and prevent adding/update parent transactions with categories
@actual-github-bot actual-github-bot bot changed the title Add a functionality to split transactions repair tool to remove categories from parent transactions and prevent adding/update parent transactions with categories [WIP] Add a functionality to split transactions repair tool to remove categories from parent transactions and prevent adding/update parent transactions with categories Apr 25, 2025
@joel-jeremy joel-jeremy changed the title [WIP] Add a functionality to split transactions repair tool to remove categories from parent transactions and prevent adding/update parent transactions with categories Add a functionality to split transactions repair tool to remove categories from parent transactions and prevent adding/update parent transactions with categories Apr 25, 2025
Copy link
Contributor

github-actions bot commented Apr 25, 2025

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
18 9.02 MB → 9.02 MB (+493 B) +0.01%
Changeset
File Δ Size
src/components/settings/RepairTransactions.tsx 📈 +493 B (+9.70%) 4.97 kB → 5.45 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
static/js/index.js 5.95 MB → 5.95 MB (+493 B) +0.01%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/en-GB.js 5.92 kB 0%
static/js/nl.js 101.15 kB 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/pt-BR.js 119.46 kB 0%
static/js/indexeddb-main-thread-worker-e59fee74.js 13.5 kB 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/es.js 67.81 kB 0%
static/js/workbox-window.prod.es5.js 5.69 kB 0%
static/js/de.js 123.57 kB 0%
static/js/en.js 111.34 kB 0%
static/js/fr.js 127.15 kB 0%
static/js/uk.js 125.2 kB 0%
static/js/narrow.js 390.13 kB 0%
static/js/useAccountPreviewTransactions.js 1.69 kB 0%
static/js/AppliedFilters.js 10.87 kB 0%
static/js/wide.js 112.89 kB 0%
static/js/ReportRouter.js 1.65 MB 0%

Copy link
Contributor

github-actions bot commented Apr 25, 2025

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 2.29 MB → 2.29 MB (+511 B) +0.02%
Changeset
File Δ Size
packages/loot-core/src/server/tools/app.ts 📈 +613 B (+15.92%) 3.76 kB → 4.36 kB
packages/loot-core/src/server/transactions/index.ts 📈 +181 B (+3.12%) 5.66 kB → 5.84 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
kcab.worker.js 2.29 MB → 2.29 MB (+511 B) +0.02%

Smaller

No assets were smaller

Unchanged

No assets were unchanged

Copy link

netlify bot commented Apr 25, 2025

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 3ebfdd9
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/680c3188dcb1e40008123833
😎 Deploy Preview https://deploy-preview-4889.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@joel-jeremy joel-jeremy changed the title Add a functionality to split transactions repair tool to remove categories from parent transactions and prevent adding/update parent transactions with categories Add a functionality to split transactions repair tool to remove categories from parent transactions + prevent adding/update parent transactions with categories Apr 26, 2025
@joel-jeremy joel-jeremy changed the title Add a functionality to split transactions repair tool to remove categories from parent transactions + prevent adding/update parent transactions with categories Add a functionality to split transactions repair tool to remove categories from parent transactions + prevent adding/updating parent transactions with categories Apr 26, 2025
@joel-jeremy joel-jeremy changed the title Add a functionality to split transactions repair tool to remove categories from parent transactions + prevent adding/updating parent transactions with categories Split transactions repair tool to remove categories from parent transactions + prevent adding/updating parent transactions with categories Apr 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant