Update chunk #65
Merged
Update chunk #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually, ESP32 is still broken with 2.0.0 release version of BSP. I had some of the proposed updates in place for the above testing. With 2.0.0 release (this is just #64 again):
|
ladyada
requested changes
Sep 27, 2021
Adafruit_I2CDevice.cpp
Outdated
| return true; | ||
| size_t pos = 0; | ||
| while (pos < len) { | ||
| size_t read_len = len - pos > maxBufferSize() ? maxBufferSize() : len - pos; |
There was a problem hiding this comment.
i really dislike trinary here, plz add parens at least
ladyada
approved these changes
Sep 27, 2021
|
thank uuuuu |
|
np. this is how it should have been to begin with :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
writeand reverts back to original non-chunk code.readto work directly on buffer passed inTested with AMG8833
pixel_testexample on an UNO and Feather ESP32 for chunk cases and Qt Py M0 for non-chunk case.UNO
Can see the chunks on the read (gap in SCL):
Feather ESP32
Can see the chunks on the read (gap in SCL):
Qt Py M0
No chunks needed here:
