Pass context directly #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing the `ctx` context allows the composed component to gain access to the `req` and `res` objects on the server side.
|
Brill. Thank you! |
|
@thealjey I updated the package. Could you confirm the next-apollo-example still works with this change? It seems to have broken server side rendering on my end. Something to do with the ctx getting passed down. https://github.com/ads1018/next-apollo-example |
|
Works fine when I remove the pathname from the header component. Not sure why... |
|
Update: had to use withRouter HOC inside the Header component. Completely unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing the
ctxcontext allows the composed component to gain access to thereqandresobjects on the server side.