pip uninstall afdko fails

[miguelsousa]

Running pip uninstall afdko fails like this,

Exception:
Traceback (most recent call last):
  File "/Users/msousa/fdk-test/lib/python2.7/site-packages/pip/basecommand.py", line 215, in main
    status = self.run(options, args)
  File "/Users/msousa/fdk-test/lib/python2.7/site-packages/pip/commands/uninstall.py", line 76, in run
    requirement_set.uninstall(auto_confirm=options.yes)
  File "/Users/msousa/fdk-test/lib/python2.7/site-packages/pip/req/req_set.py", line 346, in uninstall
    req.uninstall(auto_confirm=auto_confirm)
  File "/Users/msousa/fdk-test/lib/python2.7/site-packages/pip/req/req_install.py", line 754, in uninstall
    paths_to_remove.remove(auto_confirm)
  File "/Users/msousa/fdk-test/lib/python2.7/site-packages/pip/req/req_uninstall.py", line 115, in remove
    renames(path, new_path)
  File "/Users/msousa/fdk-test/lib/python2.7/site-packages/pip/utils/__init__.py", line 267, in renames
    shutil.move(old, new)
  File "/usr/local/Cellar/python/2.7.14/Frameworks/Python.framework/Versions/2.7/lib/python2.7/shutil.py", line 316, in move
    copy2(src, real_dst)
  File "/usr/local/Cellar/python/2.7.14/Frameworks/Python.framework/Versions/2.7/lib/python2.7/shutil.py", line 144, in copy2
    copyfile(src, dst)
  File "/usr/local/Cellar/python/2.7.14/Frameworks/Python.framework/Versions/2.7/lib/python2.7/shutil.py", line 96, in copyfile
    with open(src, 'rb') as fsrc:
IOError: [Errno 2] No such file or directory: '/Users/msousa/fdk-test/bin/buildcff2vf'

[cjchapman]

The pip uninstall afdko process seems to queue up both mixed case and lowercase versions of the same file names for removal, e.g.:

Uninstalling afdko-2.6.24:
...
  /Users/cchapman/Envs/fdk_install_test/bin/buildCFF2VF
...
  /Users/cchapman/Envs/fdk_install_test/bin/buildcff2vf
 ...

...even though only the mixed case version of the file name actually exists (i.e. buildCFF2VF).

It does that for all of these files:

buildCFF2VF
buildcff2vf
buildMasterOTFs
buildmasterotfs
checkOutlinesUFO
checkoutlinesufo
compareFamily
comparefamily
copyCFFCharstrings
copycffcharstrings
makeInstances
makeinstances
makeInstancesUFO
makeinstancesufo
stemHist
stemhist

…but it only looks for the mixed case version (and not the lowercase version) of:

mergeFonts

@anthrotype, any idea why this might be happening?

[frankrolf]

Is the case even important? Quick command-line tests don’t fail, for instance:

touch FILE.txt
rm file.txt

Maybe a file is removed twice and fails the 2nd time around?

[cjchapman]

@frankrolf, yes, that's exactly the problem, it's getting removed the first time, and then we get the failure that Miguel reported the second time. It successfully removed buildCFF2VF and then threw an exception when it tried to remove buildcff2vf.

[khaledhosny]

There are also case-sensitive file systems.

[frankrolf]

Oh yes, of course. pip also has to work on Windows, my apologizes.

[anthrotype]

windows is case insensitive too. Linux is case sensitive.
(I haven't looked into the issue with pip uninstall yet, sorry..)

[cjchapman]

The pip show -f command only shows the mixed case file names:

$ pip show -f afdko | grep -i "buildcff2vf"
  ../../../bin/buildCFF2VF
  afdko/Tools/SharedData/FDKScripts/buildCFF2VF.py
  afdko/Tools/SharedData/FDKScripts/buildCFF2VF.pyc

[miguelsousa]

@cjchapman do you know what actually gets installed? Is it camel case or all lowercase? Is that true for all platforms?

[cjchapman]

@miguelsousa, mixed case is what is actually installed on OS X. I haven't tried any other platforms.

[miguelsousa]

Then why is the process trying to uninstall the lowercased variants?

[cjchapman]

I don't know, that's what I'm trying to figure out.

[cjchapman]

This issue seems to be related: pypa/pip#2834

I can confirm that when I step through the pip code in the debugger while uninstalling afdko that I hit this line in ConfigParser.py:

                        optname = self.optionxform(optname.rstrip())

which brings us to this code, also in ConfigParser.py:

    def optionxform(self, optionstr):
        return optionstr.lower()

[miguelsousa]

I was just cross referencing your list with the contents of setup.py. You singled out mergeFonts. Does the same happen to rotateFont? If yes, then this issue seems to affect only console scripts.

[cjchapman]

I missed it earlier.

For mergeFonts and rotateFont it only tries to remove the mixed case version.

[cjchapman]

I did the experiment of renaming all the target filenames in entry_points['console_scripts'] in setup.py to lowercase and confirmed that I can cleanly pip uninstall afdko in that case (on my Mac, at least).

@miguelsousa, should I proceed with this workaround? Also what are your thoughts on renaming mergeFonts and rotateFont to be all lowercase for consistency?

[miguelsousa]

Yes, that seems fine to me.
As for renaming mergeFonts and rotateFont I'd leave them as is.

[anthrotype]

looks like it's a known issue of pip (the label says "awaiting PR")
pypa/pip#3801

[anthrotype]

and this duplicate issue pypa/pip#4771

[cjchapman]

@anthrotype, also pypa/pip#2834, as I mentioned earlier

[cjchapman]

At least we know we're not alone in dealing with this problem. :-)

[miguelsousa]

Fixed by c79e754