Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TS Strict ButtonGroup #3185

Merged
merged 5 commits into from
Jun 16, 2022
Merged

TS Strict ButtonGroup #3185

merged 5 commits into from
Jun 16, 2022

Conversation

snowystinger
Copy link
Member

Closes

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@snowystinger snowystinger mentioned this pull request Jun 1, 2022
Closed
@adobe-bot
Copy link

Build successful! 🎉

reidbarber
reidbarber previously approved these changes Jun 7, 2022
View reviewed changes
@adobe-bot
Copy link

Build successful! 🎉

LFDanLu
LFDanLu previously approved these changes Jun 9, 2022
View reviewed changes
Copy link
Member

@LFDanLu LFDanLu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering where that MutableRefObject change was coming from and realized that is the type of refs created by useRef, ugh. We'll have to update this in a lot of places I'm guessing haha

@snowystinger snowystinger dismissed stale reviews from LFDanLu and reidbarber via afe98ce June 10, 2022 19:09
@adobe-bot
Copy link

Build successful! 🎉

@adobe-bot
Copy link

Build successful! 🎉

@adobe-bot
Copy link

Build successful! 🎉

@snowystinger snowystinger merged commit f4a887e into main Jun 16, 2022
@snowystinger snowystinger deleted the ts-strict-buttongroup branch June 16, 2022 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reidbarber reidbarber reidbarber approved these changes

@LFDanLu LFDanLu LFDanLu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@snowystinger @adobe-bot @reidbarber @LFDanLu