TS Strict update react-aria 'b' and 'L' #3930
Conversation
# Conflicts: # packages/@react-aria/landmark/src/useLandmark.ts # packages/@react-aria/landmark/stories/Landmark.stories.tsx # packages/@react-aria/landmark/test/useLandmark.test.tsx
|
Build successful! 🎉 |
# Conflicts: # packages/@react-aria/landmark/src/useLandmark.ts
|
Build successful! 🎉 |
| }, 100); | ||
| }); | ||
| }) as EventListener); |
There was a problem hiding this comment.
# Conflicts: # tsconfig.json
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
| @@ -244,10 +244,10 @@ class LandmarkManager implements LandmarkManagerApi { | |||
| private closestLandmark(element: Element) { | |||
| let landmarkMap = new Map(this.landmarks.map(l => [l.ref.current, l])); | |||
| let currentElement = element; | |||
| while (currentElement && !landmarkMap.has(currentElement) && currentElement !== document.body) { | |||
| while (currentElement && !landmarkMap.has(currentElement as FocusableElement) && currentElement !== document.body && currentElement.parentElement) { | |||
There was a problem hiding this comment.
nit: make the type of the argument FocusableElement so it is only needed in one place?
There was a problem hiding this comment.
Sure will make a followup
There was a problem hiding this comment.
urgh, merge conflicts, I'll take care of it here since I'll have to get a new review anyways
|
Build successful! 🎉 |
# Conflicts: # packages/@react-aria/listbox/src/useOption.ts
snowystinger
dismissed stale reviews from devongovett, LFDanLu, and ktabors
via
46a0046
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
## API Changes
unknown top level export { type: 'identifier', name: 'Column' } @react-aria/landmarkuseLandmark useLandmark {
props: AriaLandmarkProps
- ref: MutableRefObject<FocusableElement>
+ ref: RefObject<FocusableElement>
returnVal: undefined
} |
Closes
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: