Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data.Integer.Properties.+-isAbelianGroup should be called +-0-isAbelianGroup #1844

Closed
Taneb opened this issue Oct 6, 2022 · 2 comments · Fixed by #1862
Closed

Data.Integer.Properties.+-isAbelianGroup should be called +-0-isAbelianGroup #1844

Taneb opened this issue Oct 6, 2022 · 2 comments · Fixed by #1862
Labels
naming

Comments

@Taneb
Copy link
Member

Taneb commented Oct 6, 2022

This is consistent with the other names in the module as well as Data.Rational.Properties
This was referenced Oct 20, 2022
Closed
Merged
jamesmckinna added a commit to jamesmckinna/agda-stdlib that referenced this issue Oct 24, 2022
@jamesmckinna
[fix] issue agda#1844
9ebdbb9
@jamesmckinna
Copy link
Contributor

Additionally, the raw bundles in Data.Integer.Properties should move to Data.Integer.Base as per issue #1755 PR #1810, etc.

jamesmckinna added a commit to jamesmckinna/agda-stdlib that referenced this issue Oct 24, 2022
@jamesmckinna
[fix] issue agda#1844
62b5bf2
@jamesmckinna jamesmckinna linked a pull request Oct 24, 2022 that will close this issue
[fix] issue #1844 #1862
Merged
MatthewDaggitt pushed a commit that referenced this issue Oct 26, 2022
@jamesmckinna
Fix #1844 by renaming abelian group proof for integers and moving raw…
c2302f4 
… bundles (#1862)
@jamesmckinna
Copy link
Contributor

Oh, and the Monoids in ``Rational.*` should have the names of their units added to the bundle names... sigh.

@jamesmckinna jamesmckinna mentioned this issue Oct 28, 2022
Merged
jamesmckinna added a commit to jamesmckinna/agda-stdlib that referenced this issue Oct 30, 2022
@jamesmckinna
Fix agda#1844 by renaming abelian group proof for integers and moving…
3107967 
… raw bundles (agda#1862)
@andreasabel andreasabel mentioned this issue Jul 24, 2023
Merged
@andreasabel andreasabel mentioned this issue Aug 27, 2023
Merged
@andreasabel andreasabel mentioned this issue Oct 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
naming
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[fix] issue #1844 jamesmckinna/agda-stdlib
3 participants
@Taneb @MatthewDaggitt @jamesmckinna