Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies of Reflection.AST.Argument.Information #1864

Open
MatthewDaggitt opened this issue Oct 25, 2022 · 4 comments
Open

Dependencies of Reflection.AST.Argument.Information #1864

MatthewDaggitt opened this issue Oct 25, 2022 · 4 comments

Comments

@MatthewDaggitt
Copy link
Contributor

Type-checking the above module seems to drag in a huge amount of unnecessary stuff. It must be possible to simplify the dependencies. Also check other Reflection.AST modules!

jamesmckinna added a commit to jamesmckinna/agda-stdlib that referenced this issue Oct 31, 2022
@jamesmckinna
Copy link
Contributor

jamesmckinna commented Nov 1, 2022

The above PR is a fix to this specific issue regarding imports. A more serious effort would refactor much of this code, consisting as it does in each module of how to write a decidable equality on a non-dependent product, given decidable equality on the underlying types, and then prove injectivity of such equality, given injectivity on the underlying types etc cf #698, #799, #803. There might then be knock-on consequences regarding what should then be im/ex/ported?

@jamesmckinna
Copy link
Contributor

The relevant proofs of -injective involved are all of the form λ where refl → refl , refl FWIW, but not inlined as such.

@gallais
Copy link
Member

gallais commented Jul 3, 2023

I have developed a new scoring system based on the size of the imported
transitive dependencies and the number of children and Reflection.AST.Term
shows up bright red because it imports so many Data.X.

We should probably wait until the first chunk of cleanups has landed but this is
indeed a good place to look into (cc @Saransh-cpp in case they're interested).

@Saransh-cpp
Copy link
Contributor

Saransh-cpp commented Jul 3, 2023

I can take this up (Reflection.AST.Term and others)! A lot of the Data.X and Relation.Binary.X imports should ideally go away in the ongoing PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants