Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add _≥_, _>_, _≱_ and _≯_ systematically to the Relation.Binary.Bundles hierarchy #2098

Closed
jamesmckinna opened this issue Sep 16, 2023 · 4 comments · Fixed by #2162
Closed

Comments

@jamesmckinna
Copy link
Contributor

jamesmckinna commented Sep 16, 2023

See #1214 #2095 #2096 and #2099 for further discussion.

There is a design issue at stake here, however: do we use

pro the first is that we can be more selective about imports, renaming, hiding etc. (needed in those PRs)
pro the second is that it is 'more lightweight', yet somehow more irrevocable.

My current thinking is: defined symbols

UPDATED: one two reasons I may have hesitated to pursue this already to a PR might have been:

@jamesmckinna jamesmckinna changed the title Add _≥_, _>_, _≱_ and _>_ systematically to the Relation.Binary.Bundles hierarchy Add _≥_, _>_, _≱_ and _≯_ systematically to the Relation.Binary.Bundles hierarchy Sep 16, 2023
jamesmckinna added a commit to jamesmckinna/agda-stdlib that referenced this issue Sep 16, 2023
@jamesmckinna
Copy link
Contributor Author

jamesmckinna commented Sep 26, 2023

It's a breaking change, but/hence I think worth pushing through for v2.0?

@jamesmckinna
Copy link
Contributor Author

jamesmckinna commented Oct 4, 2023

Well... in my frenzy of the last few weeks I had thought I had opened a PR for this, on the model of #2095 and #2099 .
But it seems as though I was mistaken, and mistaken in thinking I had the energy to try to knock this one off for v2.0 as well. Maybe tomorrow.

UPDATED: the evolution of #2095 (despite its recent merger!) suggests that some more thinking is required, esp. re the breaking changes as regards user experience, so I'm going to suggest punting this to v2.1 or later, unless someone else has the energy for it.

@MatthewDaggitt MatthewDaggitt added this to the v2.0 milestone Oct 5, 2023
jamesmckinna added a commit to jamesmckinna/agda-stdlib that referenced this issue Oct 7, 2023
jamesmckinna added a commit to jamesmckinna/agda-stdlib that referenced this issue Oct 7, 2023
@MatthewDaggitt
Copy link
Contributor

So the negated orders have been added. But the flipped orders are still to go.

@jamesmckinna
Copy link
Contributor Author

Bravo! Heroic effort in bringing this one over the line!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment