-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add _≥_
, _>_
, _≱_
and _≯_
systematically to the Relation.Binary.Bundles
hierarchy
#2098
Comments
_≥_
, _>_
, _≱_
and _>_
systematically to the Relation.Binary.Bundles
hierarchy_≥_
, _>_
, _≱_
and _≯_
systematically to the Relation.Binary.Bundles
hierarchy
It's a breaking change, but/hence I think worth pushing through for v2.0? |
Well... in my frenzy of the last few weeks I had thought I had opened a PR for this, on the model of #2095 and #2099 . UPDATED: the evolution of #2095 (despite its recent merger!) suggests that some more thinking is required, esp. re the breaking changes as regards user experience, so I'm going to suggest punting this to v2.1 or later, unless someone else has the energy for it. |
So the negated orders have been added. But the flipped orders are still to go. |
Bravo! Heroic effort in bringing this one over the line! |
See #1214 #2095 #2096 and #2099 for further discussion.
There is a design issue at stake here, however: do we use
Relation.Binary.*
#2095 , De-symmetrisingRelation.Binary.Bundles.Preorder._∼_
#2099)syntax
declarations?pro the first is that we can be more selective about
import
s,renaming
,hiding
etc. (needed in those PRs)pro the second is that it is 'more lightweight', yet somehow more irrevocable.
My current thinking is: defined symbols
UPDATED:
onetwo reasons I may have hesitated to pursue this already to a PR might have been:Relation.Binary.Bundles.Preorder._∼_
#2099 (merged) and [fixes #1214] Add negated ordering relation symbols systematically toRelation.Binary.*
#2095 (not yet) before proceedingThe text was updated successfully, but these errors were encountered: