Suppress warnings from Algebra.Properties.CommutativeMonoid
#1100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure how you'd prove these things generically. Happy to see us taking our |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whilst trying to improve #1078 I've run into several other outstanding issues:
Data.Fin.Permutationwhich we also want to deprecate.Foldable#1099) we want to prove most of these lemmas over someFoldabletype rather than once each for list/vector/vecTherefore to me, it feels that if we fix these problems by naively transferring the proofs over to
Vectorwe're simply generating more code we're going to need to deprecate in the future. This is therefore an alternative PR to #1078 which simply suppresses the warnings for the mean time, and we can tackle the problem more completely inv1.4.@gallais thoughts?