Deprecate Algebra.Operations.CommutativeMonoid
#1351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first stage of deprecating the
Algebra.Operations.Xmodules (whereXis some bundle) which currently scale poorly as more operations are added and are implemented very inconsistently:The new design is
Algebra.Properties.X.Y(whereXis some bundle andYis some operation). This separates individual operations out, improving modularity and inheritance of properties from different bundles in the hierarchy.This initial PR handles the
CommutativeMonoidbundle. As well as implementing the changes described above, it also switches over to usingData.Vec.Functionalfor summations instead of the deprecatedData.Table, which should go someway to unsticking #1287.