Make the RingSolver work with generic rings (#1116) #1769
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gallais
reviewed
Jul 22, 2022
| open import Tactic.RingSolver.Core.AlmostCommutativeRing | ||
|
|
||
|
|
||
| module IntegerExamples where |
There was a problem hiding this comment.
You could add these examples to the existing README.Tactic.RingSolver?
|
@felixwellen unless you have any objections in the next week or so I'll close this PR as it's going stale? |
|
Yes, I think it can be closed. From my vague memories, the status was, that I didn't understand why some expressions do not normalize and I don't think it is worth figuring out. |
gallais
added
status: won't-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work on issue #1116 . So far, this only concerns the problem that deBruijn-indices have to be adjusted when using the forall-version of the solver macro.