Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stage 2 of refactoring of Relation.Nullary #1869

Merged
merged 4 commits into from
Oct 30, 2022
Merged

Stage 2 of refactoring of Relation.Nullary #1869

merged 4 commits into from
Oct 30, 2022

Conversation

MatthewDaggitt
Copy link
Contributor

Deprecates and cleans up the imports

Relation.Nullary.Product
Relation.Nullary.Sum
Relation.Nullary.Implication

@MatthewDaggitt MatthewDaggitt added this to the v2.0 milestone Oct 26, 2022
@MatthewDaggitt MatthewDaggitt changed the title State 2 of refactoring of Relation.Nullary Stage 2 of refactoring of Relation.Nullary Oct 26, 2022
@MatthewDaggitt MatthewDaggitt merged commit 7602ca3 into master Oct 30, 2022
@MatthewDaggitt MatthewDaggitt deleted the nullary-deprecation branch October 30, 2022 13:10
@jamesmckinna jamesmckinna mentioned this pull request Oct 30, 2022
Closed
@jamesmckinna
Copy link
Contributor

jamesmckinna commented Oct 30, 2022 •
edited
Loading

Asleep at the wheel, so I missed these:

  • Relation.Nullary.Negation.Core has two redundant imports
  • open import Data.Bool.Base using (not)
  • open import Data.Product.Base using (_×_; _,_; proj₁; proj₂)

Suggest a second round of import-bashing through this PR and its predecessor #1855?
UPDATED Additionally, can tighten those for

  • Relation/Nullary/Decidable.agda
  • Relation/Nullary/Negation.agda
  • Relation/Nullary/Reflects.agda

@MatthewDaggitt
Copy link
Contributor Author

Sorry, only just seen this. Yes, would welcome these import changes 👍

@andreasabel andreasabel mentioned this pull request Jul 24, 2023
Merged
@jamesmckinna jamesmckinna mentioned this pull request Aug 14, 2023
Closed
9 tasks
@andreasabel andreasabel mentioned this pull request Aug 27, 2023
Merged
@andreasabel andreasabel mentioned this pull request Oct 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
deprecation refactoring
Projects
None yet
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@MatthewDaggitt @jamesmckinna