Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

punchOut preserves ordering #1913

Merged
merged 3 commits into from
Feb 20, 2023
Merged

punchOut preserves ordering #1913

merged 3 commits into from
Feb 20, 2023

Conversation

Taneb
Copy link
Member

@Taneb Taneb commented Jan 24, 2023

No description provided.

@jamesmckinna
Copy link
Contributor

These all look plausible/reasonable (and contribute to your ongoing investigation of Permutation{.TranspositionList}), but I can't help... wondering... if writing down the function-graph view of punchIn and punchOut might not provide a (better?) 'shrink-wrapped' approach to lemmas of this kind (and their many friends in the library), precisely by encapsulating in one place all and only the pattern analyses relevant to the computational behaviour/call-graph of the functions.

@Taneb
Copy link
Member Author

Taneb commented Jan 24, 2023

@jamesmckinna I'm afraid I don't know what you mean by "function-graph view" here. As it seems like it's off-topic to the question of whether to merge this PR in the immediate term, could I ask you to message me on Zulip about it?

@jamesmckinna
Copy link
Contributor

@Taneb happy to take the discussion elsewhere, but I'm not at all sure it's off topic. But I'll let you make that judgment.

@jamesmckinna
Copy link
Contributor

jamesmckinna commented Feb 7, 2023

For definiteness, I'd sent a preliminary version of the PunchOut one of these to @Taneb
but I'd happily raise a (competing, sorry) PR for these three views of the corresponding functions, with the corresponding properties derived, if there were interest in further discussion. Oh, GitHib doesn't support drag-and-drop of filetype .agda... so I'll make a branch... here
See PR #1921

@MatthewDaggitt MatthewDaggitt merged commit 692b6fa into agda:master Feb 20, 2023
jamesmckinna added a commit to jamesmckinna/agda-stdlib that referenced this pull request Apr 17, 2023
plt-amy pushed a commit that referenced this pull request Jul 21, 2023

Verified

This commit was signed with the committer’s verified signature.
plt-amy Amélia
This reverts commit 692b6fa.
@andreasabel andreasabel mentioned this pull request Aug 27, 2023
MatthewDaggitt pushed a commit that referenced this pull request Oct 13, 2023
andreasabel pushed a commit that referenced this pull request Jul 10, 2024
@andreasabel andreasabel mentioned this pull request Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants