-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename Relation.Binary.Construct.(Flip/Converse)
#1979
Conversation
Thanks, looks great! Good questions as well 👍
Yes, please!
If the old modules are kept then it should go under the "Deprecated modules" section |
@Saransh-cpp the tests are showing there's still a reference to the old names left in. |
|
Hmm yes, there are no direct imports of I think the tests started failing once I removed the contents of |
Relation.Binary.Construct.Flip -> Relation.Binary.Construct.Flip.Ord Relation.Binary.Construct.Converse -> Relation.Binary.Construct.Flip.EqAndOrd
7746386
to
5fb8983
Compare
Ah, I had to literally use "DEPRECATED" in the file. This works now. Thanks @jamesmckinna @MatthewDaggitt! |
This PR has a filename spelling mistake src/Relation/Binary/Construct/Flip.Agda (the uppercase As a consequence, I cannot update my working copy to
Fixed by 3041cea |
Eek nice spot. Thank you @andreasabel |
Woops, missed that, thanks! |
Fixes #1757
Renamed -
Relation.Binary.Construct.Flip
->Relation.Binary.Construct.Flip.Ord
Relation.Binary.Construct.Converse
->Relation.Binary.Construct.Flip.EqAndOrd
A few questions -
CHANGELOG
entry go in theNon-backwards compatible changes
section?Thanks!