Eliminate many propositional equality imports #2002
Merged
+282
−266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Taneb
force-pushed
the
eliminate-propeq-import
branch
from
0af4850 to
ccd3c81
Compare
gallais
reviewed
Jun 27, 2023
|
Also please don't force push the changes if you make any, it'll be a lot easier to |
Co-authored-by: G. Allais <[email protected]>
gallais
approved these changes
Jul 6, 2023
plt-amy
pushed a commit
that referenced
this pull request
Jul 21, 2023
* Eliminate many propositional equality imports * Fix merge conflict in Data.Bool.Properties Co-authored-by: G. Allais <[email protected]> --------- Co-authored-by: G. Allais <[email protected]>
Merged
MatthewDaggitt
pushed a commit
that referenced
this pull request
Oct 13, 2023
* Eliminate many propositional equality imports * Fix merge conflict in Data.Bool.Properties Co-authored-by: G. Allais <[email protected]> --------- Co-authored-by: G. Allais <[email protected]>
andreasabel
pushed a commit
that referenced
this pull request
Jul 10, 2024
* Eliminate many propositional equality imports * Fix merge conflict in Data.Bool.Properties Co-authored-by: G. Allais <[email protected]> --------- Co-authored-by: G. Allais <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many of the remaining imports of
Relation.Binary.PropositionalEqualityuse either_≗_or→-to-⟶. Moving_≗_toRelation.Binary.PropositionalEquality.Corefeels like a clear win, except it's defined in a little bit of an indirect way that pulls in some more imports