Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Data.Product imports #2003

Merged
merged 3 commits into from
Jun 30, 2023

Conversation

Saransh-cpp
Copy link
Contributor

@Saransh-cpp Saransh-cpp commented Jun 22, 2023

Some straightforward simplifications of Data.Product to Data.Product.Base.

This PR does not get rid of all the Data.Product imports. I'll be creating PRs for the same.

@gallais
Copy link
Member

gallais commented Jun 22, 2023

Some of these are already covered by #1995. We should maybe wait for that PR
to be merged to avoid duplicating too much work.

@Saransh-cpp
Copy link
Contributor Author

Ah, yes, missed that, I'll mark this as draft and rebase once the original PR is merged.

@Saransh-cpp Saransh-cpp marked this pull request as draft June 22, 2023 16:40
@Saransh-cpp
Copy link
Contributor Author

The majority of the Data.Product imports were indeed only using Data.Product.Base. I've simplified all of the Data.Product imports (excluding the ones importing , ∃-syntax, ...) in my fork and will create PRs iteratively to avoid confusion.

The imports that I could not simplify involved importing , ∃-syntax, ... from Data.Product. Moving , ∃-syntax, ... to Data.Product.Base will simplify every Data.Product import in the library to Data.Product.Base, but I'm not sure if that should be done.

@Saransh-cpp
Copy link
Contributor Author

Ah, #1995 already moves the problematic variables and operators to Data.Product.Base.

@MatthewDaggitt
Copy link
Contributor

#1995 is now merged, so this can be rebased.

@Saransh-cpp Saransh-cpp marked this pull request as ready for review June 27, 2023 14:44
@MatthewDaggitt MatthewDaggitt added this to the v2.0 milestone Jun 30, 2023
@MatthewDaggitt MatthewDaggitt merged commit 4059e66 into agda:master Jun 30, 2023
@Saransh-cpp Saransh-cpp deleted the Data.Product-take-1 branch June 30, 2023 15:35
plt-amy pushed a commit that referenced this pull request Jul 21, 2023
@andreasabel andreasabel mentioned this pull request Aug 27, 2023
andreasabel pushed a commit that referenced this pull request Jul 10, 2024
@andreasabel andreasabel mentioned this pull request Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants