Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconciling Data.Nat.Divisibility.Core._∣_ and Algebra.Definitions.RawMagma._∣_ #2013

Merged
merged 7 commits into from
Jul 29, 2023

Conversation

jamesmckinna
Copy link
Contributor

@jamesmckinna jamesmckinna commented Jul 2, 2023

See the discussion on issue #1919.

Two Three parts to this:

  • low-hanging fruit: added pattern synonym and consequences/uses of it to Data.Nat.*
  • higher-hanging fruit: reconcile the two definitions of _∣_ for the Data.Nat.Base.*-rawMagma instance
  • knock-on changes for Data.Integer.Divisibility.* and Data.Rational.* only if the preceding step succeeds

Proposal: merge the low-hanging fruit one now, and keep this branch, and the above checkboxes, open for a subsequent independent PR. In the meantime, a chance to think about the pro/contra proposals regarding how to reconcile the various definitions...

Sorry, something went wrong.

Copy link
Contributor

@JacquesCarette JacquesCarette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code up to this point of completion makes sense to me and seems to be a clear improvement.

@jamesmckinna
Copy link
Contributor Author

Label status:ready as a placeholder for 'enough commits from my side' ;-)

Copy link
Contributor

@JacquesCarette JacquesCarette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Continues to be nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants