Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise definitions of Data.List.Base.scanl|inits; add Data.List.NonEmpty.Base.scanl⁺|inits⁺ #2269

Closed
wants to merge 10 commits into from
Closed

Revise definitions of Data.List.Base.scanl|inits; add Data.List.NonEmpty.Base.scanl⁺|inits⁺ #2269

wants to merge 10 commits into from

Conversation

jamesmckinna
Copy link
Contributor

@jamesmckinna jamesmckinna commented Jan 29, 2024 •
edited
Loading

Fixes #2267 . See also the discussion on #2258 .

@jamesmckinna
Copy link
Contributor Author

Hmmm, looks as though I've screwed up the CHANGELOG.

@JacquesCarette
Copy link
Contributor

Yes, other than that, this looks really good!

@jamesmckinna
Copy link
Contributor Author

Hopefully that's sorted out now.

@jamesmckinna jamesmckinna mentioned this pull request Jan 30, 2024
Closed
@jamesmckinna
Copy link
Contributor Author

So I think we've (now) agreed to find a better home for this (and #2258 ) under Data.List.Something. Suggestions welcome!

@jamesmckinna
Copy link
Contributor Author

Aaargh: Data.List.Kleene.*!

@jamesmckinna jamesmckinna mentioned this pull request Apr 12, 2024
Merged
andreasabel
andreasabel reviewed May 22, 2024
View reviewed changes
Copy link
Member

@andreasabel andreasabel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvements!

In general, some list operations always return non-empty lists, so this should be expressed in types; and then one can choose to forget the extra information of non-emptiness using a conversion to plain lists.

@jamesmckinna jamesmckinna mentioned this pull request May 23, 2024
Merged
@jamesmckinna
Copy link
Contributor Author

Now see #2395

@jamesmckinna jamesmckinna deleted the scanl branch May 30, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreasabel andreasabel andreasabel left review comments

Assignees
No one assigned
Labels
addition refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

A 'better' (less strict) Data.List.Base.tails?
3 participants
@jamesmckinna @JacquesCarette @andreasabel