Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[imports] Algebra.Apartness.Bundles .. Algebra.Construct.NaturalChoice.Base #2597

Merged
merged 2 commits into from
Feb 28, 2025

Conversation

jmougeot
Copy link
Contributor

No description provided.

@jmougeot jmougeot marked this pull request as ready for review February 20, 2025 20:10
@JacquesCarette JacquesCarette changed the title Apartness & Construct [imports] Algebra.Apartness.Bundles .. Algebra.Construct.NaturalChoice.Base Feb 26, 2025
Copy link
Contributor

@jamesmckinna jamesmckinna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe @JacquesCarette takes the 'contra' view?

@@ -13,7 +13,7 @@ open import Relation.Binary.Core using (Rel)
open import Relation.Binary.Bundles using (ApartnessRelation)
open import Algebra.Core using (Op₁; Op₂)
open import Algebra.Bundles using (CommutativeRing)
open import Algebra.Apartness.Structures
open import Algebra.Apartness.Structures using (IsHeytingCommutativeRing; IsHeytingField)
Copy link
Contributor

@jamesmckinna jamesmckinna Feb 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I'm against this change: the design of the various hierarchies is such that for each X.Structures, there will be a corresponding X.Bundles reifying the corresponding structures. So that if new structures get added, then Bundles will need to know about them.

The contra view would be that by being explicit, it catches potential bugs caused by not adding the corresponding structures, but I think (hope!) that's a minor consideration?

I've raised this as a point on the originating issue #2339 .

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm definitely a "I want to know, by reading, where something came from" kind of person. Importing 'everything' means you need to use interaction to do that.

It's not at all obvious that Algebra.Apartness.Structures defines anything with Heyting in the name (unless you know a lot already), so this serves as extra documentation too.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JacquesCarette All good points.

The specific use of 'Heyting' is a separate issue... #2588 and we might wish to completely revise these downstream one day, but yes, your general point stands.

(off-topic, but related: does increasing the information content/redundant recoding by making using directives so precise affect, positively, how AI systems might exploit this data? certainly the orthodox cognitive dimensions story about redundant recoding implies a trade-off with viscosity, but that's for humans, not machines... )

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My guess was that AI would feed from decoded .agdai information which have all of that in them [i.e. all traceability information is visible there, regardless of what humans did in the source.]

@jamesmckinna jamesmckinna added this pull request to the merge queue Feb 28, 2025
Merged via the queue into agda:master with commit 452f619 Feb 28, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants