[Refactor] imports to use Relation.Nullary.Irrelevant
#2676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Taneb
requested changes
Mar 14, 2025
|
I just added the changelog entry, but I’m not sure if I did it correctly. |
|
Also a good idea, for the sake of the GitHub history, to explicitly mention #2624 , which this now does over as a 'clean' PR. |
jamesmckinna
requested changes
Mar 15, 2025
Co-authored-by: jamesmckinna <[email protected]>
JacquesCarette
requested changes
Mar 15, 2025
CHANGELOG.md
Outdated
| @@ -120,6 +120,8 @@ New modules | |||
|
|
|||
| * `Data.Sign.Show` to show a sign | |||
|
|
|||
| * `Relation.Nullary.Irrelevant` defining the concept of irrelevance (h-proposition), where all elements of a type are equal. | |||
There was a problem hiding this comment.
While this is a new module, it really is a refactoring, so this isn't quite the right place to put this. I'm sure previous CHANGELOGs have such entries that can be used as a guide on how to do this.
jmougeot
changed the title
Relation.Nullary.Irrelevant #2624
jmougeot
changed the title
Relation.Nullary.Irrelevant #2624Relation.Nullary.Irrelevant
jamesmckinna
approved these changes
Mar 17, 2025
Co-authored-by: jamesmckinna <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update imports to replace references to
Relation.NullarywithRelation.Nullary.Irrelevantwhere applicable, enhancing clarity and organization in the codebase. #2624