[WIP] fix: enable clean shutdown of all workers and processes #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ishandhanani
requested review from
hutm,
biswapanda,
julienmancuso,
hhzhang16,
nnshah1,
tanmayv25,
piotrm-nvidia,
ptarasiewiczNV,
ryanolson,
grahamking,
paulhendricks,
tmonty12,
GuanLuo,
rmccorm4,
tedzhouhk,
alec-flowers and
kkranen
as code owners
ryanolson
reviewed
Apr 1, 2025
| @@ -186,7 +189,33 @@ async def worker(runtime: DistributedRuntime): | |||
| logger.error(f"[{run_id}] Error in Dynamo component setup: {str(e)}") | |||
| raise | |||
|
|
|||
| asyncio.run(worker()) | |||
| # Define the setup_signal_handlers function within main's scope | |||
| async def setup_signal_handlers(): | |||
There was a problem hiding this comment.
should this go in the @dynamo_worker decorator in the python bindings?
There was a problem hiding this comment.
Good idea - I'm getting back to this and will try
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's been a couple different issues people running into lingering zombie processes even after you run a
ctrl-c. Many times these are VLLM processes. This PR does 2 thingsasync_shutdownhook allowing our reference examples to use things likeshutdown_background_loop()from the VLLM AsyncLLMEngine code.As of right now - I have tested on 4 examples and think I have (1) working.