-
Notifications
You must be signed in to change notification settings - Fork 227
Pin the Click version to 7.0. #3837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The recent update to Click (7.1) breaks our tests and this CI workflow, because the help output formatting was slightly changed. Until we have resolved other issues we should pin the Click version to 7.0.
Codecov Report
@@ Coverage Diff @@
## develop #3837 +/- ##
========================================
Coverage 77.16% 77.16%
========================================
Files 458 458
Lines 33770 33770
========================================
Hits 26058 26058
Misses 7712 7712
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright
Just for reference @csadorf , for most PR's, especially for single commit one's we prefer to use squash-and-merge instead of a normal merge. The linear history and absence of unnecessary merge-commits makes the history easier to follow. We still use normal merges where appropriate such as the merging of feature branches. For multi commit PRs where we don't want to squash we use rebase and merge. |
Agreed that the current name doesn't describe its full content very well. Sounds like a more broad title or a separate page would be a good solution |
The recent update to Click (7.1) breaks our tests and this CI workflow,
because the help output formatting was slightly changed.
Until we have resolved other issues we should pin the Click version to
7.0.
Because of this incidence, I have added "Click" to the list of problematic dependencies.