Skip to content

Pin the Click version to 7.0. #3837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 9, 2020
Merged

Pin the Click version to 7.0. #3837

merged 1 commit into from
Mar 9, 2020

Conversation

csadorf
Copy link
Contributor

@csadorf csadorf commented Mar 9, 2020

The recent update to Click (7.1) breaks our tests and this CI workflow,
because the help output formatting was slightly changed.

Until we have resolved other issues we should pin the Click version to
7.0.

Because of this incidence, I have added "Click" to the list of problematic dependencies.

The recent update to Click (7.1) breaks our tests and this CI workflow,
because the help output formatting was slightly changed.

Until we have resolved other issues we should pin the Click version to
7.0.
@codecov
Copy link

codecov bot commented Mar 9, 2020

Codecov Report

Merging #3837 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #3837   +/-   ##
========================================
  Coverage    77.16%   77.16%           
========================================
  Files          458      458           
  Lines        33770    33770           
========================================
  Hits         26058    26058           
  Misses        7712     7712
Flag Coverage Δ
#django 69.2% <ø> (ø) ⬆️
#sqlalchemy 70.02% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e30935...c61ef49. Read the comment docs.

@csadorf csadorf requested a review from ltalirz March 9, 2020 17:12
Copy link
Member

@ltalirz ltalirz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright

@csadorf csadorf merged commit 035fbba into develop Mar 9, 2020
@csadorf csadorf deleted the dm/pin-click-7.0 branch March 9, 2020 17:20
@sphuber
Copy link
Contributor

sphuber commented Mar 10, 2020

Just for reference @csadorf , for most PR's, especially for single commit one's we prefer to use squash-and-merge instead of a normal merge. The linear history and absence of unnecessary merge-commits makes the history easier to follow. We still use normal merges where appropriate such as the merging of feature branches. For multi commit PRs where we don't want to squash we use rebase and merge.

@csadorf
Copy link
Contributor Author

csadorf commented Mar 10, 2020

@sphuber Thank's for letting me know. I see that these policies are documented here, however I did not originally see this, because I don't find the page name "Git style requirements" very descriptive. Maybe we can rename it or even have a separate page about "Merge policies" or so?

@sphuber
Copy link
Contributor

sphuber commented Mar 10, 2020

Agreed that the current name doesn't describe its full content very well. Sounds like a more broad title or a separate page would be a good solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants