Update Supplier.php

[switch-cheehau]

add supplier.addressformat as configuration

refer to #239
Sorry, i've screwed up the commits in previous PR. re-create this PR for clean code.

[coveralls]

Coverage decreased (-2.3%) to 86.296% when pulling 5997c7a on cgcomputers:make-supplier-address-format-configurable into ebf17e5 on aimeos:master.

[aimeos]

You should use a default value if it's not set like:

$format = $this->getConfigValue( 'supplier.addressformat', 'short' );
$attributes['supplier.address'] = $this->feConfig['supplier.code'][$format][$code];

[switch-cheehau]

Can i do it in oneline?

$attributes['supplier.address'] = $this->feConfig['supplier.code'][$this->getConfigValue('supplier.addressformat','short')][$code];

[aimeos]

Yes but the line will be very long and we try to keep the line length below 120 chars.

[switch-cheehau]

ah, okay, understand, i'll change.

[switch-cheehau]

done

[aimeos]

We've discussed this a bit internally and came to the conclusion that adding just another format may not fit the requirements of many users as they may have different wishes for the address format depending on the country and/or intended use.

Our recommendation would be to add the format string directly to the configuration instead of a fixed list of format options.

[switch-cheehau]

We've discussed this a bit internally and came to the conclusion that adding just another format may not fit the requirements of many users as they may have different wishes for the address format depending on the country and/or intended use.

Our recommendation would be to add the format string directly to the configuration instead of a fixed list of format options.

make sense.
If you need my help to continue the PR,
do you have any existing example that i can refer to implement the changes?

[aimeos]

Yes, your help would be valuable :-)
The solution is to use that string from provider configuration: https://github.com/aimeos/aimeos-core/blob/master/lib/mshoplib/src/MShop/Service/Provider/Decorator/Supplier.php#L72-L82

[switch-cheehau]

create new PR for different approach.