Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport][3.7][PR#5498] Fix how pure-Python HTTP parser interprets // #5499

Merged
merged 1 commit into from
Feb 25, 2021

Conversation

webknjaz
Copy link
Member

(cherry picked from commit f2afa2f)

What do these changes do?

Are there changes in behavior for the user?

This makes the HTTP queries with a leading double slash to
be parsed as a query-path and not a hostname by the
pure-Python HTTP parser.

Related issue number

N/A

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@webknjaz webknjaz requested a review from asvetlov as a code owner February 25, 2021 17:21
@webknjaz webknjaz self-assigned this Feb 25, 2021
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Feb 25, 2021
@codecov
Copy link

codecov bot commented Feb 25, 2021

Codecov Report

Merging #5499 (dc2dfa7) into 3.7 (5c1efbc) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##              3.7    #5499   +/-   ##
=======================================
  Coverage   97.55%   97.55%           
=======================================
  Files          44       44           
  Lines        8818     8820    +2     
  Branches     1419     1419           
=======================================
+ Hits         8602     8604    +2     
  Misses        101      101           
  Partials      115      115           
Flag Coverage Δ
unit 97.39% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiohttp/http_parser.py 97.52% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c1efbc...b61f0fd. Read the comment docs.

@webknjaz webknjaz merged commit b61f0fd into 3.7 Feb 25, 2021
@webknjaz webknjaz deleted the backport/3.7/bugfixes/request-line-py-vs-cext-parsers branch February 25, 2021 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant