-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more Swin backbones for RetinaNet and VFNet #1042
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1042 +/- ##
==========================================
- Coverage 85.96% 85.95% -0.02%
==========================================
Files 272 281 +9
Lines 5794 5922 +128
==========================================
+ Hits 4981 5090 +109
- Misses 813 832 +19
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
"https://raw.githubusercontent.com/dnth/mmdetection_configs/custom-configs/configs/swin/retinanet_swin-t-p4-w7_fpn_1x_coco.py", | ||
"https://raw.githubusercontent.com/dnth/mmdetection_configs/custom-configs/configs/swin/retinanet_swin-s-p4-w7_fpn_1x_coco.py", | ||
"https://raw.githubusercontent.com/dnth/mmdetection_configs/custom-configs/configs/swin/retinanet_swin-b-p4-w7_fpn_1x_coco.py", | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can add your new config files in the airctic/mmdetection_configs
"https://raw.githubusercontent.com/dnth/mmdetection_configs/custom-configs/configs/swin/retinanet_swin-t-p4-w7_fpn_1x_coco.py",
"https://raw.githubusercontent.com/dnth/mmdetection_configs/custom-configs/configs/swin/retinanet_swin-s-p4-w7_fpn_1x_coco.py",
"https://raw.githubusercontent.com/dnth/mmdetection_configs/custom-configs/configs/swin/retinanet_swin-b-p4-w7_fpn_1x_coco.py"
We have to find a way to make sure those files don't get lost when we upgrade to a new mmdet version (e.g. mmdet 2.21.0)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refactored this after a video conference with Farid. Custom config files are added into the mmdetection_configs
in a separate folder.
@dnth Do you have a notebook where you tested either RetinaNet or VFNet with Swin? What are the COCO metric for 20 iterations? (it must be low because of the un-trainede Neck) |
Here is a Colab notebook I ran |
During my test, I find that for VFNet model to run, we have to keep the |
Thanks a lot @dnth! We should continue using 🔥 VFNet rocks! 66% with Un-trained Neck is mind blowing! I just confirm my preference towards that model! I think the PR is ready to get merged🚀 |
This PR: