Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid setting userAgent when it's already set #473

Merged
merged 1 commit into from
May 19, 2022

Conversation

kt3k
Copy link
Contributor

@kt3k kt3k commented May 18, 2022

navigator.userAgent has become getter-only property at denoland/deno#14415, and we can't set it anymore. This PR avoids error with that

Copy link
Member

@ije ije left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ije ije merged commit bb011a2 into alephjs:main May 19, 2022
@kt3k kt3k deleted the fix/do-not-set-user-agent-when-already-set branch May 19, 2022 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants