Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cargo): Update minimal dependency versions so that 'cargo build -Z minimal-versions' works #205

Merged

Conversation

klausi
Copy link
Contributor

@klausi klausi commented Apr 2, 2018

The crate does not compile with cargo build -Z minimal-versions because a lot of minimal versions are underspecified. I bumped them until I could build successfully.

Ideally we should also add something like cargo update -Z minimal-versions && cargo build to the Travis CI config so that this does not happen again in the future. I'm not sure where to put that exactly?

@alexcrichton
Copy link
Owner

Thanks so much!

Sounds like a great idea to me to add this to CI eventually (and I think long-term we'd even do this on cargo publish). For the time being though I think it's ok to skip that as it's still a nightly Cargo feature and otherwise this lib isn't changing a whole lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants