-
Notifications
You must be signed in to change notification settings - Fork 203
Emscripten support #301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Emscripten support #301
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit worried about the growth of the usage of #[cfg]
here, while windows/unix is pretty simple adding windows/unix/wasm/not-emscripten is getting a bit much. Would you be willing to integrate the cfg-if
crate to clean up these definitions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I'm trying to port a project to |
I've been taking a look at the PR, and it's becoming challenging to read between different |
I'm having this problem too. FWIW, the way I hacked around this was by replacing |
This is a pretty old PR at this point clocking in at ~2.5 years, so yeah if you're interested I think it'd be best to probably start with a new PR and go from there? |
Updated as #397 |
The target
wasm32-unknown-emscripten
is considered bothwasm32
andunix
, so the currentmaster
branch does not compile with multiple definition errors. This PR fixes this. Some of the tests checking file mtimes and symlinks still fail on Emscripten, this could be addressed later.Relies on alexcrichton/filetime#88.