Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve split-operator documentation #1024

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Lewiscowles1986
Copy link

I've added a high level description which I think better classifies and summarises this approach to solving a problem.

I've used the term meta algorithm, because this can be applied to a wide number of problems, with different, contextual and situational concrete algorithms.

I've added a high level description which I think better classifies and summarises this approach to solving a problem.

I've used the term meta algorithm, because this can be applied to a wide number of problems, with different, contextual and situational concrete algorithms.
@leios
Copy link
Member

leios commented Feb 15, 2025

Wait, I might be confused here. So my understanding was that:

  1. The split operator method almost always refers to what's presented in the text as is. That is, a specific method that splits up the operators in a hamiltonian to solve them in their specific spaces. The split-step Fourier method is the same algorithm under a different name
  2. The split-step method (without the Fourier distinction) is as you say, a general class of algorithms that can be used in a variety of different situations.

@Lewiscowles1986
Copy link
Author

Maybe I need to further improve this, and I've over-genericised the text.

If I'm honest, I was a little... What? while reading this, so I was trying to simplify from a process of collating a few sources.

I'd welcome feedback if I've made the text harder to understand, or misunderstood any of the materials, because I am not a quantumn theoretical computer scientist, or theoretical physicist

Copy link
Member

@leios leios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so I think I am starting to see the issue here.

  1. Though "Split operator method" is usually the split-step fourier method, there are many people who use the term to refer to operator splitting, in general. Once the splitting is done, there is no need to really use the fourier transform for the solution.
  2. This means that the title of this chapter should be "Split-step fourier method" instead of "split-operator method".

@@ -1,5 +1,9 @@
# The Split-Operator Method
The Split-Operator Method (also called the Split-Step Method), was actually the primary method I used to solve the Schrödinger equation during my PhD.
The Split-Operator Method (also called the Split-Step Method) can be best understood, as a problem-solving approach or meta-algorithm rather than a standalone algorithm, which solves a single problem.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I am understanding where you are coming from this statement. I see some of the references still had operator splitting, but did not specifically use the Split-step fourier method. Even though in practice the SSFM is the most common approach used for the split operator method, I think it should be made more explicit in the text that there is a difference between these approaches.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I have a question here. Should I make the change in my branch to call this, "split-step fourier method", or have I really just taken us both down a rabbit hole which is unhelpful?

Copy link
Member

@leios leios Feb 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I come back to this? I think what might happen is that I will create a new PR that is co-authored with you with the necessary changes. This discussion is a good one, I just have to rethink about how to package it.

It'll take like 10 minutes, but I might not have that time available until later this week.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its not urgent to me. This was sort of me thinking I was helping, but maybe I'm not

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the record, the conversation is definitely helpful! Thanks

Co-authored-by: James Schloss <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants