Adding Python 3 euclidean example #138
Conversation
june128
added
the
Implementation
| @@ -0,0 +1,28 @@ | |||
| # submitted by KerimovEmil | |||
| def euclid_mod(a, b): | |||
|
|
|||
There was a problem hiding this comment.
I don't think it's very usual to start a function with an empty line (at least not according to pep8). Other than that the implemrntation looks good.
There was a problem hiding this comment.
If you do fix this (which I think you should), make sure to change it in the python2-implementation as well
There was a problem hiding this comment.
I can make this change in both files.
|
Let's wait with this until #141 is resolved. |
…name. Not sure what the conclusion of #141 will be, but it seems like python 3 will be staying.
|
You can remove the python 2 code and replace mentions of python3/py3 by python/py |
|
Honestly, after #168, all this PR does is remove a blank line and add your name. I'm sorry @KerimovEmil the Python side of the AAA was taken by a sudden storm and chaos ensued. I think I will close this PR, hopefully you can find some other chapter to contribute to. |
|
Yeah #168 essentially implemented everything this PR was going to do after the change, not sure why that one was merged before this one though. I don't mind closing this PR, I'm sure there are lots of chapters to contribute to. |
|
@KerimovEmil I think #168 just changed a few lines, but we are no longer splitting python 2 and python 3, so there is no need for two separate python versions. |
Adding Python 3 euclidean example