simplifying julia code for monte carlo #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's an improvement. Leaving |
zsparal
suggested changes
Jun 29, 2018
| function in_circle(x_pos::Float64, y_pos::Float64) | ||
|
|
||
| # Setting radius to 1 for unit circle | ||
| radius = 1 | ||
| if (x_pos^2 + y_pos^2 < radius^2) |
There was a problem hiding this comment.
This should be return x_pos^2 + y_pos^2 < radius^2 in my opinion. I don't like unnecessary if/else blocks
|
The overeager @leios merge strikes again 😃 |
|
Oh, shoot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey guys, a lot of people were mentioning that the julia code for monte carlo was unclear. After looking at it again, I agree. I really wanted to have some parameter
radiusin the function, just because I wanted to make it clear that the circle could be an arbitrary size. That said, @jiegillet brought it to my attention, that we clearly say we are using a unit circle in the code, and if we read in a radius of greater than the box length, the code is wrong.For this purpose, I removed the
radiusparameter from the julia code (except in thein_circle()function, but I can remove it there too). I was just being overly cautious to try to make the text easier to read and understand and in the process actually made it more difficult for new contributors.Let me know what you think. I should probably just remove the
radiusfrom thein_circle()function too, now that I think about it.We need to put code in that makes sense, so whatever you guys think is best should be what we go with here.