Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding some templates to be modified in review #569

Merged
merged 22 commits into from
Mar 21, 2019

Conversation

leios
Copy link
Member

@leios leios commented Jan 2, 2019

I am still working on the chapter submission guidelines, but I figured we could go ahead and put these up for review in the meantime. Don't merge until that section of the wiki is completed!

Copy link
Member

@june128 june128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a first round of review covering a typos and general structural aspects.

june128 and others added 15 commits March 17, 2019 09:14
@june128
Copy link
Member

june128 commented Mar 21, 2019

The headings of the different parts of the templates are currently realized by using bold text (**text**).
I think we should rather use the heading syntax (#, ## and ###). This would enable the creator of an issue/PR to use bold text in the actual text and it also adds more structure to the templates.
I therefore created a PR over on your repo that changes the headings: leios#3

…eading_notation

Use markdown heading notation and add more structure.
Copy link
Member

@june128 june128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last round of change requests.

Copy link
Member

@june128 june128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to add this one change request.

@june128 june128 changed the title WIP adding some templates to be modified in review adding some templates to be modified in review Mar 21, 2019
@june128 june128 merged commit fa4a998 into algorithm-archivists:master Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants