Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit Complexity Notation in #352 #601

Merged

Conversation

dovisutu
Copy link
Contributor

Fixing problems in #352 about Complexity Notation Chapter

  • adding O != Omega example
  • Using println as an operation
  • fixing the overflow problem in exponational algorithm
  • Using a real logarithmic algorithm and edit the explanation

@leios
Copy link
Member

leios commented Apr 12, 2019

This is a quick fix for the problem at-hand and I don't mind merging it. The main thing is that this chapter goes against the philosophy of all other "code" in the AAA and only has julia-esque pseudocode instead of actual code in other languages. I suppose I need to re-write this so it allows for real methods to be written in whatever language instead of using weird println() statements.

@june128 june128 added the Chapter Edit This changes the archive's chapters. (md files are edited.) label May 6, 2019
Copy link
Member

@Amaras Amaras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I'm now going through the backlog, I don't mind merging it as well, like @leios said a long time ago, if that's still the case for him.
I have a few Eglish language-related changes to make, so I won't approve yet.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link
Member

@Amaras Amaras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From there, I'll merge this chapter edit, since it has been too long since the last review that asked for simple text changes.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@Amaras Amaras merged commit 5dae366 into algorithm-archivists:main Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chapter Edit This changes the archive's chapters. (md files are edited.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants