Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added C++ compilation #939

Merged
merged 2 commits into from
Nov 22, 2021
Merged

Conversation

Amaras
Copy link
Member

@Amaras Amaras commented Nov 22, 2021

I added the compilation infrastructure for C++.

I had to add the -std=c++17 option because the Barnsley fern code would not compile without it.

Apart from that, everything compiles successfully in the right folder on my machine 😃

Copy link
Contributor

@ShadowMitia ShadowMitia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks fine. I'm wondering, maybe we should already add a few more flags? Like -pedantic -Wextra -Wall -Werror?
I'm not saying being exhaustive, but already have a minimal setup for future contributions.

@Amaras
Copy link
Member Author

Amaras commented Nov 22, 2021

I'm wondering, maybe we should already add a few more flags? Like -pedantic -Wextra -Wall -Werror?

That's something I want to have, but we need to fix warnings before we can do that.

Copy link
Member

@leios leios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me, happy to approve!

@ShadowMitia
Copy link
Contributor

I'm wondering, maybe we should already add a few more flags? Like -pedantic -Wextra -Wall -Werror?

That's something I want to have, but we need to fix warnings before we can do that.

That makes sense

@Amaras
Copy link
Member Author

Amaras commented Nov 22, 2021

Okay, after careful consideration, I think we should have this merged as soon as possible, so we can move on.
I really want to come back to fixing the warnings, but we need to keep going while there is a bit of momentum left.

In short, I'm merging this in.

@Amaras Amaras merged commit 465e1e8 into algorithm-archivists:master Nov 22, 2021
@Amaras Amaras deleted the cpp_compilation branch November 22, 2021 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants