Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Go to SCons #947

Merged
merged 1 commit into from
Nov 28, 2021
Merged

Add Go to SCons #947

merged 1 commit into from
Nov 28, 2021

Conversation

PeanutbutterWarrior
Copy link
Contributor

@PeanutbutterWarrior PeanutbutterWarrior commented Nov 28, 2021 •
edited
Loading

Adds Go to SCons.

Probably should be checked on docker, but it's probably too simple to fail.

Amaras
Amaras approved these changes Nov 28, 2021
View reviewed changes
Copy link
Member

@Amaras Amaras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

I think in the future, we should think about separating the builders from the SConstruct.

However, it is not necessary for now. 

@Amaras Amaras merged commit c3c0938 into algorithm-archivists:master Nov 28, 2021
@Amaras Amaras mentioned this pull request Nov 28, 2021
Open
45 tasks
@PeanutbutterWarrior PeanutbutterWarrior deleted the add-go-to-scons branch November 29, 2021 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Amaras Amaras Amaras approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PeanutbutterWarrior @Amaras