Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Box muller chapter #974

Merged
merged 19 commits into from
May 6, 2022
Merged

Box muller chapter #974

merged 19 commits into from
May 6, 2022

Conversation

leios
Copy link
Member

@leios leios commented Dec 9, 2021

Amaras said there were now only 2 pages of PRs. I couldn't have that, so here's a draft for the upcoming chapter.

There are a lot of images and such missing, but the text is mostly there. I think I will be just slammin' through the images / videos tomorrow on stream.

My main concern here is that the benchmarking section is actually roughly the same length as the rest of the chapter and I wonder if I should siphon it out into it's own subchapter or not. In general, I could imagine that being a common thing to do with future chapters:

  1. The base algorithm
  2. Ok, but how do we make this efficient?

@ShadowMitia ShadowMitia added the Chapter This provides a new chapter. (md files are edited) label Dec 28, 2021
@leios leios marked this pull request as ready for review March 15, 2022 15:51
@leios
Copy link
Member Author

leios commented Mar 17, 2022

So the last thing we need here is some sort of test to prove the 2D code does actually provide a Gaussian

@leios leios merged commit 8693a37 into algorithm-archivists:main May 6, 2022
@leios leios deleted the box_muller branch May 6, 2022 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chapter This provides a new chapter. (md files are edited)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants