-
Notifications
You must be signed in to change notification settings - Fork 62
database instrumentation supports semconv 1.30. #367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
database instrumentation supports semconv 1.30. #367
Conversation
b6c3ac4
to
01df671
Compare
56f85eb
to
5bd8ba5
Compare
Update to semconv v1.30. |
b450103
to
999824c
Compare
c22f509
to
cdb6740
Compare
cdb6740
to
7c14e52
Compare
Seems that the failed TestLatestDepth cases is unrelated to the PR itself. |
The underlying fiber uses the fasthttp, I will fix that |
66ad2be
to
b01387a
Compare
b01387a
to
2ee744c
Compare
2ee744c
to
ef900ae
Compare
|
63bfe74
to
7cb0633
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, @NameHaibinZhang feel free to review it
7cb0633
to
9a79c15
Compare
@123liuziming |
Yes, I will split all the tests into different pipelines later. For now, just increase the timeout for running TestPlugins |
OK, I'll also temporarily set the timeout to 90 minutes as part of this PR. |
9a79c15
to
f65f6a4
Compare
Since currently we still use semconv v1.26.0 which does not include
db.collection.name
, I defined it as a constant.NOTICE:
This feature only supports SQL statements that can be parsed by SQL parser packages. If non-standard SQL is used, the span name will fall back to the previous one. For more information, refer here.
Ref: #364
before:

after:
