Skip to content

feat: allow to build offline with -mod=vendor #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2025
Merged

Conversation

y1yang0
Copy link
Member

@y1yang0 y1yang0 commented Apr 15, 2025

There is a scenario where we want users to rely on our package (alibaba/pkg/core),
and after executing go mod vendor, all related dependencies are fetched
locally. The subsequent build process can then be performed offline,
without relying on go mod tidy/vendor to fetch any additional dependencies.
Therefore, we need to proactively list all hook-related code and their
potential dependencies in advance and import them here.
This makes no sense for most users, but it does make sense for users whose
build machine is not connected to the internet.

@codecov-commenter
Copy link

codecov-commenter commented Apr 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.52%. Comparing base (ef76c15) to head (54f2e83).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #403   +/-   ##
=======================================
  Coverage   83.52%   83.52%           
=======================================
  Files          27       27           
  Lines        1196     1196           
=======================================
  Hits          999      999           
  Misses        159      159           
  Partials       38       38           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@y1yang0 y1yang0 changed the title feat: allow to build offline feat: allow to build offline with -mod=vendor Apr 15, 2025
@NameHaibinZhang NameHaibinZhang merged commit e8b4fe5 into main Apr 15, 2025
9 checks passed
@y1yang0 y1yang0 deleted the yyang/vendored branch April 15, 2025 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants