-
Notifications
You must be signed in to change notification settings - Fork 11.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: search.liquid over all collections #2447
Merged
george-gca
merged 3 commits into
alshedivat:master
from
CheariX:feat-search-all-collections
May 27, 2024
Merged
feat: search.liquid over all collections #2447
george-gca
merged 3 commits into
alshedivat:master
from
CheariX:feat-search-all-collections
May 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
george-gca
requested changes
May 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add spaces between the variables and the {{ }}
, so they all look like {{ var }}
instead of {{var }}
or {{ var}}
? Nice addition btw.
Good catch :-) |
george-gca
requested changes
May 27, 2024
george-gca
approved these changes
May 27, 2024
siril-teja
pushed a commit
to siril-teja/siril-teja.github.io-old
that referenced
this pull request
Jun 19, 2024
Thank you @george-gca for the awesome work. on alshedivat#2415. This PR generalizes the search on all collections. Currently, only projects are added to the search. This PR uses all of them, such as news. On my personal website, I use a teaching collection which is then also automatically searched.
karapostK
pushed a commit
to karapostK/karapostK.github.io
that referenced
this pull request
Jul 4, 2024
Thank you @george-gca for the awesome work. on alshedivat#2415. This PR generalizes the search on all collections. Currently, only projects are added to the search. This PR uses all of them, such as news. On my personal website, I use a teaching collection which is then also automatically searched.
Suraj-Bhor
pushed a commit
to Suraj-Bhor/suraj-bhor.github.io
that referenced
this pull request
Aug 13, 2024
Thank you @george-gca for the awesome work. on alshedivat#2415. This PR generalizes the search on all collections. Currently, only projects are added to the search. This PR uses all of them, such as news. On my personal website, I use a teaching collection which is then also automatically searched.
meiqing-wang
pushed a commit
to meiqing-wang/meiqing-wang.github.io
that referenced
this pull request
Oct 13, 2024
Thank you @george-gca for the awesome work. on alshedivat#2415. This PR generalizes the search on all collections. Currently, only projects are added to the search. This PR uses all of them, such as news. On my personal website, I use a teaching collection which is then also automatically searched.
avishekanand
pushed a commit
to avishekanand/al-folio-homepage
that referenced
this pull request
Oct 22, 2024
Thank you @george-gca for the awesome work. on alshedivat#2415. This PR generalizes the search on all collections. Currently, only projects are added to the search. This PR uses all of them, such as news. On my personal website, I use a teaching collection which is then also automatically searched.
mattleblanc
pushed a commit
to mattleblanc/mattleblanc.github.io
that referenced
this pull request
Dec 29, 2024
Thank you @george-gca for the awesome work. on alshedivat#2415. This PR generalizes the search on all collections. Currently, only projects are added to the search. This PR uses all of them, such as news. On my personal website, I use a teaching collection which is then also automatically searched.
MarcinWiech
pushed a commit
to MarcinWiech/marcinwiech.github.io
that referenced
this pull request
Feb 28, 2025
Thank you @george-gca for the awesome work. on alshedivat#2415. This PR generalizes the search on all collections. Currently, only projects are added to the search. This PR uses all of them, such as news. On my personal website, I use a teaching collection which is then also automatically searched.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you @george-gca for the awesome work. on #2415.
This PR generalizes the search on all collections. Currently, only projects are added to the search.
This PR uses all of them, such as news. On my personal website, I use a teaching collection which is then also automatically searched.