Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: search.liquid over all collections #2447

Merged
merged 3 commits into from
May 27, 2024

Conversation

CheariX
Copy link
Contributor

@CheariX CheariX commented May 27, 2024

Thank you @george-gca for the awesome work. on #2415.

This PR generalizes the search on all collections. Currently, only projects are added to the search.
This PR uses all of them, such as news. On my personal website, I use a teaching collection which is then also automatically searched.

Copy link
Collaborator

@george-gca george-gca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add spaces between the variables and the {{ }}, so they all look like {{ var }} instead of {{var }} or {{ var}}? Nice addition btw.

@CheariX
Copy link
Contributor Author

CheariX commented May 27, 2024

Good catch :-)

@george-gca george-gca merged commit e8a2a40 into alshedivat:master May 27, 2024
3 checks passed
@CheariX CheariX deleted the feat-search-all-collections branch May 27, 2024 15:32
siril-teja pushed a commit to siril-teja/siril-teja.github.io-old that referenced this pull request Jun 19, 2024
Thank you @george-gca for the awesome work. on alshedivat#2415.

This PR generalizes the search on all collections. Currently, only
projects are added to the search.
This PR uses all of them, such as news. On my personal website, I use a
teaching collection which is then also automatically searched.
karapostK pushed a commit to karapostK/karapostK.github.io that referenced this pull request Jul 4, 2024
Thank you @george-gca for the awesome work. on alshedivat#2415.

This PR generalizes the search on all collections. Currently, only
projects are added to the search.
This PR uses all of them, such as news. On my personal website, I use a
teaching collection which is then also automatically searched.
Suraj-Bhor pushed a commit to Suraj-Bhor/suraj-bhor.github.io that referenced this pull request Aug 13, 2024
Thank you @george-gca for the awesome work. on alshedivat#2415.

This PR generalizes the search on all collections. Currently, only
projects are added to the search.
This PR uses all of them, such as news. On my personal website, I use a
teaching collection which is then also automatically searched.
meiqing-wang pushed a commit to meiqing-wang/meiqing-wang.github.io that referenced this pull request Oct 13, 2024
Thank you @george-gca for the awesome work. on alshedivat#2415.

This PR generalizes the search on all collections. Currently, only
projects are added to the search.
This PR uses all of them, such as news. On my personal website, I use a
teaching collection which is then also automatically searched.
avishekanand pushed a commit to avishekanand/al-folio-homepage that referenced this pull request Oct 22, 2024
Thank you @george-gca for the awesome work. on alshedivat#2415.

This PR generalizes the search on all collections. Currently, only
projects are added to the search.
This PR uses all of them, such as news. On my personal website, I use a
teaching collection which is then also automatically searched.
mattleblanc pushed a commit to mattleblanc/mattleblanc.github.io that referenced this pull request Dec 29, 2024
Thank you @george-gca for the awesome work. on alshedivat#2415.

This PR generalizes the search on all collections. Currently, only
projects are added to the search.
This PR uses all of them, such as news. On my personal website, I use a
teaching collection which is then also automatically searched.
MarcinWiech pushed a commit to MarcinWiech/marcinwiech.github.io that referenced this pull request Feb 28, 2025
Thank you @george-gca for the awesome work. on alshedivat#2415.

This PR generalizes the search on all collections. Currently, only
projects are added to the search.
This PR uses all of them, such as news. On my personal website, I use a
teaching collection which is then also automatically searched.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants