Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Resume/CV Links #2826

Merged
merged 7 commits into from
Dec 3, 2024
+9 −4
Merged

Support for Resume/CV Links #2826

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
285d5fb
Add Option to add Resume/CV Link
pranjalagg Nov 4, 2024
28439f7
Prettier
pranjalagg Nov 4, 2024
57719e2
Implimented Suggestions
pranjalagg Nov 28, 2024
b33a50e
Replace http check with :// in cv.liquid
pranjalagg Nov 29, 2024
4f42faf
Space after relative_url
pranjalagg Nov 30, 2024
e7bc890
Add comment to indicate ability to include resume links
pranjalagg Dec 2, 2024
28a57a7
Comment Update
pranjalagg Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Loading
Loading status checks…
Prettier
@pranjalagg
pranjalagg committed Nov 4, 2024
commit 28439f786a78cdf0750b15adf5e25c3b6133300c
8 changes: 5 additions & 3 deletions _layouts/cv.liquid
View file
Original file line number Diff line number Diff line change
@@ -53,20 +53,22 @@ layout: default
<h1 class="post-title">
{{ page.title }}
{% if page.cv_pdf %}
{% if page.cv_pdf contains "http" %}
{% if page.cv_pdf contains 'http' %}
<a
href="{{ page.cv_pdf }}"
target="_blank"
rel="noopener noreferrer"
class="float-right">
class="float-right"
>
<i class="fa-solid fa-file-pdf"></i>
</a>
{% else %}
<a
href="{{ page.cv_pdf | prepend: 'assets/pdf/' | relative_url}}"
target="_blank"
rel="noopener noreferrer"
class="float-right">
class="float-right"
>
<i class="fa-solid fa-file-pdf"></i>
</a>
{% endif %}