Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows for standard Jekyll code highlighting with distill template #3002

Merged
merged 2 commits into from
Feb 12, 2025

Conversation

jacobaustin123
Copy link
Contributor

@jacobaustin123 jacobaustin123 commented Feb 5, 2025

As described in #300, standard Markdown code highlighting doesn't work in the Distill template because it is clobbered by the Distill "Prism" syntax highlighting. This PR will allow d-code tags (distill-specific code tags) to function with the Distill syntax highlighter, but will default highlight and Markdown code blocks to use the Jekyll/Rouge highlighter.

This PR also removes overrides.js, which is currently broken because jquery isn't loaded.

Copy link

netlify bot commented Feb 5, 2025

Deploy Preview for relaxed-lollipop-b6bc17 ready!

Name Link
🔨 Latest commit 496382b
🔍 Latest deploy log https://app.netlify.com/sites/relaxed-lollipop-b6bc17/deploys/67ab7dc758d6c60008723c7b
😎 Deploy Preview https://deploy-preview-3002--relaxed-lollipop-b6bc17.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jacobaustin123
Copy link
Contributor Author

Before:
image

After:

image

@george-gca
Copy link
Collaborator

It is missing some prettier fixes.

@jacobaustin123
Copy link
Contributor Author

I pushed a set of prettier fixes. This should now pass presubmits.

@jacobaustin123
Copy link
Contributor Author

Note that fwiw prettier is causing a bunch of bad formatting in the md file: dedenting the code blocks and unnecessarily escaping the *.

@george-gca george-gca merged commit 10d007a into alshedivat:main Feb 12, 2025
10 checks passed
@george-gca
Copy link
Collaborator

Thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants